Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable columns with virtual scroll doesn't work with p-treeTable #9575

Closed
AlexStefan opened this issue Nov 25, 2020 · 5 comments
Closed
Assignees
Labels
LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@AlexStefan
Copy link

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

Stackblitz with primeng 10.0.3
Stackblitz with primeng 11.0.0 rc

Current behavior
If you have a treetable with both the resizable columns and virtual scroll when trying to resize a column, app crashes.

Expected behavior
The resize should not crash.

Minimal reproduction of the problem with instructions
Try to resize a column.

What is the motivation / use case for changing the behavior?
n/a

Please tell us about your environment:
Stackblitz provided above

  • Angular version: 5.X
    11.0

  • PrimeNG version: 5.X
    10.0.3 and 11.0.0 rc1

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 25, 2020
@AlexStefan
Copy link
Author

Also this seems connected with this: #8885, which was just close :(

@yigitfindikli yigitfindikli added this to the 11.0.1 milestone Nov 25, 2020
@yigitfindikli yigitfindikli self-assigned this Nov 25, 2020
@yigitfindikli yigitfindikli modified the milestones: 11.0.0-Final, 11.0.1 Dec 7, 2020
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 5, 2021
@yigitfindikli
Copy link
Member

Fixed in 3d9cacf . Thanks for detailed report @AlexStefan.

@AlexStefan
Copy link
Author

Awesome! Thank you for fixing it!

@yigitfindikli yigitfindikli added the LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 label Jan 12, 2021
@yigitfindikli
Copy link
Member

@AlexStefan You're welcome :) Always happy to help!

@yigitfindikli yigitfindikli added LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 and removed LTS-PORTABLE labels Jan 12, 2021
@AlexStefan
Copy link
Author

AlexStefan commented Jan 12, 2021

offtopic a bit: @yigitfindikli can you please also check #9358 would be really helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants