Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar menuitems must have menu/menubar as parent #9680

Closed
mbquinonez opened this issue Dec 18, 2020 · 1 comment
Closed

Menubar menuitems must have menu/menubar as parent #9680

mbquinonez opened this issue Dec 18, 2020 · 1 comment
Assignees
Labels
LTS-FIXED-9.2.6 Fixed in PrimeNG LTS 9.2.6 LTS-FIXED-10.1.1 Fixed in PrimeNG LTS 10.1.1 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mbquinonez
Copy link

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Menubar component introduces wcag violation: https://dequeuniversity.com/rules/axe/4.1/aria-required-parent

Expected behavior
Component should should pass wcag2 tests

Minimal reproduction of the problem with instructions
Use Menubar component and run accessibility tool such as axe

What is the motivation / use case for changing the behavior?
Pass WCAG tests

Please tell us about your environment:
Angular version: 11

PrimeNG version: 11

Browser: Chrome

  • Angular version:
    *11

  • PrimeNG version:
    *11

  • Browser:

  • all

@yigitfindikli yigitfindikli self-assigned this Dec 25, 2020
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 25, 2020
@yigitfindikli yigitfindikli added this to the 11.1.0 milestone Dec 25, 2020
@yigitfindikli yigitfindikli modified the milestones: 11.1.0, 11.2.0 Jan 11, 2021
@yigitfindikli yigitfindikli modified the milestones: 11.2.0, 11.3.0 Jan 21, 2021
@komby
Copy link

komby commented Jan 21, 2021

@yigitfindikli Since a fix and test are already available for this change is it possible we will see it in 11.3? We need some of these a11y changes in our app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.6 Fixed in PrimeNG LTS 9.2.6 LTS-FIXED-10.1.1 Fixed in PrimeNG LTS 10.1.1 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants