Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar week days are never updated use i18n API. #9689

Closed
Tigler opened this issue Dec 24, 2020 · 3 comments
Closed

Calendar week days are never updated use i18n API. #9689

Tigler opened this issue Dec 24, 2020 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Tigler
Copy link

Tigler commented Dec 24, 2020

weekDays init in createWeekDays method with default traslate. After edit PrimeNGConfig translate weekDays not changed.

{{weekDay}}

Need use

{{weekDay}}
@Tigler
Copy link
Author

Tigler commented Dec 24, 2020

weekDays init in createWeekDays method with default traslate. After edit PrimeNGConfig translate weekDays not changed.
"<th scope="col" *ngFor="let weekDay of weekDays;let begin = first; let end = last">"

Need use
"<th scope="col" *ngFor="let weekDay of getTranslation('dayNamesMin');let begin = first; let end = last">"

@cagataycivici cagataycivici self-assigned this Dec 24, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 24, 2020
@cagataycivici cagataycivici modified the milestone: 11.1.0-rc.1 Dec 24, 2020
@cagataycivici cagataycivici removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 24, 2020
@cagataycivici cagataycivici removed their assignment Dec 24, 2020
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 25, 2020
@yigitfindikli yigitfindikli self-assigned this Dec 25, 2020
@adessilly
Copy link

Find an example of the issue below :

https://stackblitz.com/edit/primeng11-localization-bug?file=src%2Fapp%2Fapp.component.ts

The problem is the same if we want to dynamically change the firstDayOfWeek, it is never applied in the component.
There is also un bug if we change at runtime the dateFormat (it stays displayed with the previous dateFormat until we change the date).

Do you plan to fix this regression soon? Otherwise we would need to find other alternatives.

@adessilly
Copy link

Btw, for firstDayOfWeek, updateInputfield() update the field as expected :)

@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 11, 2021
@yigitfindikli yigitfindikli added this to the 11.3.1 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants