Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table: Unable to translate "No filter" in columnFilter #9709

Closed
jvdyck opened this issue Jan 4, 2021 · 0 comments
Closed

p-table: Unable to translate "No filter" in columnFilter #9709

jvdyck opened this issue Jan 4, 2021 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@jvdyck
Copy link

jvdyck commented Jan 4, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The last item of the columnFilter filter dropdown is hardcoded as "No filter", so translation is not possible.

Expected behavior
The "No filter" text should be translatable like the other items in the filter dropdown.

  • Angular version: 11.0.4

  • PrimeNG version: 11.X

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 5, 2021
@yigitfindikli yigitfindikli self-assigned this Jan 5, 2021
@yigitfindikli yigitfindikli added this to the 11.1.0 milestone Jan 5, 2021
@yigitfindikli yigitfindikli added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants