Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView does not support dynamic panel visibility #2339

Closed
nazar opened this issue Oct 8, 2021 · 0 comments
Closed

TabView does not support dynamic panel visibility #2339

nazar opened this issue Oct 8, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@nazar
Copy link

nazar commented Oct 8, 2021

I'm submitting a ... (check one with "x")

[x] bug report
[] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

https://codesandbox.io/s/determined-galileo-mzs1p

Current behavior

It is not possible to dynamically show/hide tabs in TabView/TabPanel - please see the above sandbox link. Clicking the "Toggle Header 2" button conditionally returns a false, which TabView is not able to process and crashes.

Expected behavior

Conditional rendering as document in React should be supported otherwise this is surprising behaviour.

Minimal reproduction of the problem with instructions

Clicking the "Toggle Header 2" conditionally returns a false, which TabView is not able to process and crashes.

Please tell us about your environment:

  • React version:
    17.0.2

  • PrimeReact version:
    6.5.0

@mertsincan mertsincan self-assigned this Nov 4, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 4, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants