Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable VirtualScroll alignment issue #2392

Closed
konradkoc opened this issue Nov 5, 2021 · 0 comments
Closed

DataTable VirtualScroll alignment issue #2392

konradkoc opened this issue Nov 5, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@konradkoc
Copy link

I'm submitting a ... (check one with "x")

[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

  1. When scrolling DataTable from bottom to top, virtualScroll encounters error and doesnt render any data. When inspecting the issue it seems like when event onScrollIndexChange triggers, the bug happens when e.first < 0. When I go on with scrolling to top it fixes and e.first === 0
  2. VirtualSroll content seems to be translated of virtual row size. But in my case, the header is much bigger than row size which makes the first row of dataTable not fully visible.

Expected behavior

  1. When for some reason e.first < 0 -> just use 0 with proper index shift.
  2. Use header size to translate virtualScroll content.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:
    7.0.1

  • PrimeReact version:
    7.0.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@mertsincan mertsincan self-assigned this Nov 5, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 5, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 5, 2021
@mertsincan mertsincan changed the title DataTable VirtualScroll Bugs DataTable VirtualScroll alignment issue Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants