Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showcase: Update all TypeScript samples #2490

Closed
jafin opened this issue Dec 2, 2021 · 2 comments
Closed

Showcase: Update all TypeScript samples #2490

jafin opened this issue Dec 2, 2021 · 2 comments
Assignees
@ulasturann @habubey
Labels
Component: Documentation Issue or pull request is related to Documentation Typescript Issue or pull request is *only* related to TypeScript definition

Comments

@jafin
Copy link
Contributor

jafin commented Dec 2, 2021 •
edited

I'm submitting a ...

[x] bug report

Codesandbox Case (Bug Reports)

updated code sample: https://codesandbox.io/s/cranky-wind-6v50x
Existing code sample: https://codesandbox.io/s/ykcro

Current behavior
Works but has warnings/errors.
Running the demo code from here https://primefaces.org/primereact/showcase/#/datatable/filter (TS) in codesandbox.

Expected behavior
Demo works without errors.

Launch the existing documented demo in codesandbox, note errors and warnigns.

codesandbox.

  • React version:
    17.01

  • PrimeReact version:
    7.1

  • Browser:
    Chrome.

  • Language:
    Typescript
@jafin jafin mentioned this issue Dec 2, 2021
Closed
@melloware
Copy link
Member

Related to: #2467

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 21, 2022
@mertsincan mertsincan changed the title Datatable filter (docs) : Codesandbox typescript sample code warnings Update all TypeScript samples in showcase Mar 29, 2022
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 29, 2022
@melloware melloware added the Typescript Issue or pull request is *only* related to TypeScript definition label Apr 21, 2022
@mcandu mcandu removed their assignment Jul 29, 2022
@melloware melloware mentioned this issue Sep 23, 2022
Closed
@melloware melloware changed the title Update all TypeScript samples in showcase Showcase: Update all TypeScript samples Nov 7, 2022
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Nov 11, 2022
@melloware
Copy link
Member

Closing as this is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulasturann ulasturann

@habubey habubey

Labels
Component: Documentation Issue or pull request is related to Documentation Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor (docs): Datatable example in ts compile without warnings jafin/primereact
7 participants
@jafin @melloware @mertsincan @yigitfindikli @mcandu @ulasturann @habubey