Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: Panel should remain open #2988

Closed
raDiesle opened this issue Jun 14, 2022 · 3 comments
Closed

MultiSelect: Panel should remain open #2988

raDiesle opened this issue Jun 14, 2022 · 3 comments
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@raDiesle
Copy link

Describe the bug

This issue was fixed where it was not possible to focus select/dropdown like inputs.
#2299

But introduced another issue in the way we use the components when the input is used inside of nested label tag,
where when user selects "Select all" checkbox, it will instant close.

Also there is some behavior when label is focused, that it reopens twice ( which is acceptable, but weird).

Maybe a dropdown should not reopen, when its already opened, but focused again and just stay open.

Reproducer

https://codesandbox.io/s/primereact-test-forked-rqgi4m

PrimeReact version

8.1.1

React version

17.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 102

Steps to reproduce the behavior

  1. open MultiSelect
  2. click on the checkbox ( which selects all items)

Expected behavior

When user selects all checkbox in MultiSelect, it should stay opened

@raDiesle raDiesle added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jun 14, 2022
@melloware melloware changed the title Component: MultiSelect and other Dropdowns MultiSelect: Panel should remain open Jun 18, 2022
@adamgibs
Copy link

adamgibs commented Jun 20, 2022

We are having a similar issue with this component on our site. We are using a multiselect component to toggle columns. We've noticed that with wide tables that scroll horizontally, the multiselect dropdown hides after removing a column when the table is scrolled all the way to the right. This doesn't happen when scroll is set to any other position. Here is a code sandbox example:

https://codesandbox.io/s/white-leftpad- ... small.json

@melloware melloware added 👍 confirmed and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 20, 2022
@cetincakiroglu cetincakiroglu self-assigned this Jul 4, 2022
@melloware
Copy link
Member

@melloware melloware added this to the 8.7.3 milestone Dec 7, 2022
@melloware
Copy link
Member

also not sure why appendTo={'self'} as that is not necessary right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

5 participants