Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting text type for value with indeterminate ProgressBar #368

Closed
keul opened this issue Mar 30, 2018 · 2 comments
Closed

Supporting text type for value with indeterminate ProgressBar #368

keul opened this issue Mar 30, 2018 · 2 comments
Assignees
Milestone

Comments

@keul
Copy link
Contributor

keul commented Mar 30, 2018

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=57

Current behavior
Can put any (text) value inside a ProgressBarwith indeterminate

Expected behavior
As indeterminate is not something related to numerical progress, a way to specify a text value can be really useful:

<ProgressBar mode="indeterminate" value="Loading assets" showValue />
@mertsincan mertsincan self-assigned this Apr 2, 2018
@mertsincan
Copy link
Member

Fixed for next version.
image

<ProgressBar mode="indeterminate" style={{height: '6px'}} showValue={true} value="Loading assets"></ProgressBar>

@mertsincan mertsincan added this to the 1.5.1 milestone Apr 2, 2018
@keul
Copy link
Contributor Author

keul commented Apr 16, 2018

Note: I tried this feature on version 1.5.1, although it works, the layout is a lot different from what you get with a determinate progress.
The value is displayed on top-left, visually outside the progress. I fixed this manually with CSS in my usecase but I'm wondering if there an issue with the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants