Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar Style: Multiple Months borders #3918

Closed
nazar opened this issue Jan 5, 2023 · 3 comments
Closed

Calendar Style: Multiple Months borders #3918

nazar opened this issue Jan 5, 2023 · 3 comments
Assignees
@melloware
Labels
Component: Theme Issue or pull request is related to Theme
Milestone
10.6.3

Comments

@nazar
Copy link

nazar commented Jan 5, 2023

Describe the bug

Borders between months are not displaying correctly in Calendar Multiple Months example.

This is related to primereact-designer-8.0.0, specifically the /src/assets/designer/components/input/_calendar.scss file for class .p-datepicker-multiple-month.

Screenshot 2023-01-05 at 18 04 45

Note the changed styling from border-right from v7 to border-left in v8 caused this issue. Reverting to border-right fixes the issue.

Reproducer

No response

PrimeReact version

8.7.3

React version

17.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Issue can be seen on https://www.primefaces.org/primereact/calendar/ when clicking on the Multiple Months example.

Expected behavior

Expect to see a vertical border between the middle month and the two outer months.
@nazar nazar added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 5, 2023
@melloware melloware added Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 5, 2023
@melloware
Copy link
Member

Thanks for the report I assigned to PrimeTek to update the themes.

@mertsincan mertsincan modified the milestones: 8.7.4, 10.0.0 Jan 26, 2023
@melloware melloware assigned melloware and unassigned mertsincan Jul 1, 2023
@melloware melloware mentioned this issue Jul 1, 2023
Closed
@melloware
Copy link
Member

Opened theme issue: primefaces/primereact-sass-theme#23

@melloware melloware modified the milestones: 10.0.0, 9.6.1 Jul 1, 2023
@melloware
Copy link
Member

PR Submitted there and tested!

@ulasturann ulasturann modified the milestones: 10.0.0, 11.0.0 Sep 28, 2023
@melloware melloware modified the milestones: 11.0.0, 10.6.3 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Theme Issue or pull request is related to Theme
Projects
None yet
Milestone
10.6.3
Development

No branches or pull requests
4 participants
@nazar @melloware @mertsincan @ulasturann