Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password - Toggle Mask incorrect icon positioning #6349

Closed
sja-cslab opened this issue Apr 9, 2024 · 2 comments · Fixed by #6493
Closed

Password - Toggle Mask incorrect icon positioning #6349

sja-cslab opened this issue Apr 9, 2024 · 2 comments · Fixed by #6493
Assignees
@melloware
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@sja-cslab
Copy link
Contributor

Describe the bug

Not much to say. It looks like this on all available Themes on the PrimeFaces page
image

Reproducer

No response

PrimeReact version

10.6.3

React version

18.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@sja-cslab sja-cslab added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 9, 2024
@sja-cslab sja-cslab changed the title Toggle Mask Incorrect icon positioning Password - Toggle Mask Incorrect icon positioning Apr 9, 2024
@sja-cslab sja-cslab changed the title Password - Toggle Mask Incorrect icon positioning Password - Toggle Mask incorrect icon positioning Apr 9, 2024
@melloware melloware added Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 9, 2024
@sandramfdeveloper
Copy link

@melloware This, again, can be fixed by replacing the icon with the new IconField :) (I knew the error appeared more times but I couldn't remember where).

@melloware
Copy link
Member

Yes but this is in the structure of the password component so I wasn't sure if that is how PrimeTek wanted to fix it or just put the CSS back.

@melloware melloware mentioned this issue Apr 29, 2024
Merged
@melloware melloware assigned melloware and unassigned nitrogenous and gucal Apr 29, 2024
@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
@sja-cslab sja-cslab mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
Development

Successfully merging a pull request may close this issue.

Fix #6396: Password use IconField for toggle mask melloware/primereact
5 participants
@melloware @sandramfdeveloper @nitrogenous @gucal @sja-cslab