You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the accordion component, the tab is removed from the DOM once it is closed. This could be problematic, for example, when forms and input fields are used as content, as the content of the input field is deleted when closing and reopening. Of course, one could store the content of the field in a useState (as in the example), but the problem with form validation persists because only the fields of the current tab are validated, not all of them. The entire form cannot be validated if there are form fields in the different accordion tabs.
I compared the component with other libraries like PrimeVue and PrimeNG, where the content of the DOM is NOT deleted. Is there a simple way to prevent the accordion tab from being removed from the DOM when the tab is closed?
nitrogenous
added
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Core Team
Issue or pull request has been *opened* by a member of Core Team
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
May 2, 2024
I completely agree, this makes the accordion non usable in most cases. The choice should be given to the user, if possible. Or by default, the content should be hidden but not removed from the DOM.
melloware
changed the title
AccordionTab is beeing removed from DOM on closing Tab
AccordionTab: is being removed from DOM on closing Tab
Jun 13, 2024
I tend to agree with @sja-cslab here. Removing something from the DOM is always the preferred approach as their is less in the DOM tree not being used.
melloware
added
Status: Discussion
Issue or pull request needs to be discussed by Core Team
and removed
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Core Team
Issue or pull request has been *opened* by a member of Core Team
labels
Jun 19, 2024
Describe the bug
When using the accordion component, the tab is removed from the DOM once it is closed. This could be problematic, for example, when forms and input fields are used as content, as the content of the input field is deleted when closing and reopening. Of course, one could store the content of the field in a useState (as in the example), but the problem with form validation persists because only the fields of the current tab are validated, not all of them. The entire form cannot be validated if there are form fields in the different accordion tabs.
I compared the component with other libraries like PrimeVue and PrimeNG, where the content of the DOM is NOT deleted. Is there a simple way to prevent the accordion tab from being removed from the DOM when the tab is closed?
Reproducer
https://stackblitz.com/edit/rdg6zx-hjxnyv?file=src%2FApp.jsx
PrimeReact version
10.6.4
React version
17.x
Language
TypeScript
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: