Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Maximized should not have rounded borders? #4310

Closed
zeachco opened this issue Apr 29, 2023 · 2 comments
Closed

Dialog: Maximized should not have rounded borders? #4310

zeachco opened this issue Apr 29, 2023 · 2 comments
Assignees
@zeachco @ulasturann
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
9.4.0

Comments

@zeachco
Copy link

zeachco commented Apr 29, 2023

Describe the bug

image

Maybe this is opinionated but I feel border shouldn't be rounded when maximized.

Reproducer

No response

PrimeReact version

9.3.1

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

Chrome 112

Steps to reproduce the behavior

Maximize a Dialog, see corners (maybe zoomed if DPI is too small)

Expected behavior

image
@zeachco zeachco added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 29, 2023
@zeachco zeachco mentioned this issue Apr 29, 2023
Closed
@melloware melloware changed the title Component: Dialog - Maximized should not have rounded borders? Dialog: Maximized should not have rounded borders? Apr 29, 2023
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 29, 2023
@melloware melloware added this to the 9.4.0 milestone Apr 29, 2023
@melloware
Copy link
Member

I agree with you. Assigned PrimeTek to review.

@ulasturann ulasturann self-assigned this May 9, 2023
@ulasturann
Copy link
Contributor

ulasturann commented May 9, 2023 •
edited
Loading

Thanks for the PR and issue @zeachco

Looks like we need to solve this in designer. So, I'll move the fix there and link this issue.

ulasturann added a commit that referenced this issue May 10, 2023
@ulasturann
Fİx #4310 - Dialog: Set border-radius to 0 when maximized
65e38c1
@ulasturann ulasturann mentioned this issue May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeachco zeachco

@ulasturann ulasturann

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
9.4.0
Development

Successfully merging a pull request may close this issue.

Removes border radius for maximized Dialog zeachco/primereact
3 participants
@zeachco @melloware @ulasturann