Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous Component in vue-devtools #1093

Closed
AndreasNasman opened this issue Mar 16, 2021 · 5 comments
Closed

Anonymous Component in vue-devtools #1093

AndreasNasman opened this issue Mar 16, 2021 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@AndreasNasman
Copy link

Generating a default Vue CLI project, adding primevue to it, and importing and declaring a component results in it being an Anonymous Component in the Vue.js devtools browser extension. I experimented a bit and noticed that this behavior starts happening with version 3.2.x; in 3.1.x components still have a name set.

Is this the intended behavior? Included components as SFCs generate names in the devtools with newer versions of PrimeVue.


Minimal steps to reproduce:

  1. npx @vue/cli create vue-cli-project
  2. cd vue-cli-project && yarn add primevue
  3. yarn serve
  4. Include a component
// main.js
import Button from "primevue/button";
import PrimeVue from "primevue/config";
import { createApp } from "vue";
import App from "./App.vue";

createApp(App)
  .use(PrimeVue)
  .component("Button", Button)
  .mount("#app");
  
  
// App.vue
<template>
  <Button label="test" />
</template>
  1. The component will be treated as an Anonymous Component
    image
@AndreasNasman
Copy link
Author

AndreasNasman commented Apr 1, 2021

To clarify, this happens both in Chrome and Firefox.

@cagataycivici
Copy link
Member

Seems to be related to the new build;

#1138

We'll review for 3.5.0.

@cagataycivici cagataycivici added this to the 3.5.0 milestone Apr 14, 2021
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 14, 2021
@AndreasNasman
Copy link
Author

Thanks!

@cagataycivici cagataycivici removed this from the 3.5.0 milestone May 10, 2021
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add priority - high and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 10, 2021
@mertsincan mertsincan self-assigned this May 11, 2021
@mertsincan mertsincan added this to the 3.4.1 milestone May 11, 2021
@mertsincan
Copy link
Member

Fixed now! Thanks a lot for your report!
vue_dev_tool

@AndreasNasman
Copy link
Author

Woop woop! Thanks a lot! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants