Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message icon correction #112

Closed
fairking opened this issue Dec 12, 2019 · 1 comment
Closed

Message icon correction #112

fairking opened this issue Dec 12, 2019 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@fairking
Copy link

fairking commented Dec 12, 2019

I feel that the message icons should be another way around. Is the any way to change the icons? Based on my analysis and documentation it is not possible at the moment.

  1. I think the success message must have pi-check icon and the info message must have pi-info-circle icon.
  2. Would be nice to add a property which overrides the default icon in case if you need something completely different based on the message context.
    Please let me know what do you think.

image

image

@fairking
Copy link
Author

For a while I did the following trick:

.p-messages-icon {
	&.pi-check::before {
		content: "\e924";
	}
	&.pi-info-circle::before {
		content: "\e909";
	}
}

@cagataycivici cagataycivici changed the title Message icon change Message icon correction Dec 20, 2019
@cagataycivici cagataycivici self-assigned this Dec 20, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 20, 2019
@cagataycivici cagataycivici added this to the 1.0.0-rc.2 milestone Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants