Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error using Dialog after upgrade to 3.4.0 #1224

Closed
mrichar1 opened this issue Apr 29, 2021 · 1 comment
Closed

Error using Dialog after upgrade to 3.4.0 #1224

mrichar1 opened this issue Apr 29, 2021 · 1 comment

Comments

@mrichar1
Copy link
Contributor

mrichar1 commented Apr 29, 2021 •
edited

I'm submitting a ...

[X ] bug report

Current behavior

After upgrading form 3.3.5 to 3.4.0 I get the following error using a Dialog when setting the visible bound variable to true:

[Vue warn]: Unhandled error during execution of transition hook 
  at <BaseTransition onBeforeEnter=fn<onBeforeEnter> onEnter=fn onBeforeLeave=fn<bound onBeforeLeave>  ... > 
  at <Transition name="p-dialog" onBeforeEnter=fn<bound onBeforeEnter> onEnter=fn<bound onEnter>  ... > 
  at <Dialog visible=true onUpdate:visible=fn content-style= {overflow: "visible"}  ... > 

Uncaught (in promise) TypeError: this.$primevue is undefined
    onBeforeEnter dialog.esm.js:88
    onBeforeAppear runtime-dom.esm-bundler.js:568
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    callHook runtime-core.esm-bundler.js:2338
    beforeEnter runtime-core.esm-bundler.js:2365
    mountElement runtime-core.esm-bundler.js:3934
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    componentEffect runtime-core.esm-bundler.js:4298
    reactiveEffect reactivity.esm-bundler.js:42
    effect reactivity.esm-bundler.js:17
    setupRenderEffect runtime-core.esm-bundler.js:4263
    mountComponent runtime-core.esm-bundler.js:4222
    processComponent runtime-core.esm-bundler.js:4182
    patch runtime-core.esm-bundler.js:3791
    componentEffect runtime-core.esm-bundler.js:4298
    reactiveEffect reactivity.esm-bundler.js:42
    effect reactivity.esm-bundler.js:17
    setupRenderEffect runtime-core.esm-bundler.js:4263
    mountComponent runtime-core.esm-bundler.js:4222
    processComponent runtime-core.esm-bundler.js:4182
    patch runtime-core.esm-bundler.js:3791
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    patchBlockChildren runtime-core.esm-bundler.js:4091
    process runtime-core.esm-bundler.js:5085
    patch runtime-core.esm-bundler.js:3794
    componentEffect runtime-core.esm-bundler.js:4368
    reactiveEffect reactivity.esm-bundler.js:42
    callWithErrorHandling runtime-core.esm-bundler.js:154
    flushJobs runtime-core.esm-bundler.js:384
    flushJobs runtime-core.esm-bundler.js:397
    promise callback*queueFlush runtime-core.esm-bundler.js:286
    queueJob runtime-core.esm-bundler.js:280
    run reactivity.esm-bundler.js:183
    trigger reactivity.esm-bundler.js:189
    set reactivity.esm-bundler.js:300
    set runtime-core.esm-bundler.js:6275
    onRowSelect SLDList.vue:135
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    emit runtime-core.esm-bundler.js:642
    onRowClick datatable.esm.js:3138
    26 datatable.esm.js:4439
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    emit runtime-core.esm-bundler.js:642
    onRowClick datatable.esm.js:2145
    onClick datatable.esm.js:2278
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    invoker runtime-dom.esm-bundler.js:333
    addEventListener runtime-dom.esm-bundler.js:283
    patchEvent runtime-dom.esm-bundler.js:301
    patchProp runtime-dom.esm-bundler.js:369
    mountElement runtime-core.esm-bundler.js:3905
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    mountChildren runtime-core.esm-bundler.js:3975
    processFragment runtime-core.esm-bundler.js:4141
    patch runtime-core.esm-bundler.js:3784
    mountChildren runtime-core.esm-bundler.js:3975
    processFragment runtime-core.esm-bundler.js:4141
    patch runtime-core.esm-bundler.js:3784
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    componentEffect runtime-core.esm-bundler.js:4298
    reactiveEffect reactivity.esm-bundler.js:42
    effect reactivity.esm-bundler.js:17
    setupRenderEffect runtime-core.esm-bundler.js:4263
    mountComponent runtime-core.esm-bundler.js:4222
    processComponent runtime-core.esm-bundler.js:4182
    patch runtime-core.esm-bundler.js:3791
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
dialog.esm.js:88
    flushJobs runtime-core.esm-bundler.js:397
    flushJobs runtime-core.esm-bundler.js:397
    (Async: promise callback)
    queueFlush runtime-core.esm-bundler.js:286
    queueJob runtime-core.esm-bundler.js:280
    run reactivity.esm-bundler.js:183
    forEach self-hosted:4328
    trigger reactivity.esm-bundler.js:189
    set reactivity.esm-bundler.js:300
    set runtime-core.esm-bundler.js:6275
    onRowSelect SLDList.vue:135
    onRowSelect self-hosted:1173
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    emit runtime-core.esm-bundler.js:642
    emit self-hosted:1220
    onRowClick datatable.esm.js:3138
    onRowClick self-hosted:1173
    26 datatable.esm.js:4439
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    emit runtime-core.esm-bundler.js:642
    emit self-hosted:1220
    onRowClick datatable.esm.js:2145
    onRowClick self-hosted:1173
    onClick datatable.esm.js:2278
    callWithErrorHandling runtime-core.esm-bundler.js:154
    callWithAsyncErrorHandling runtime-core.esm-bundler.js:163
    invoker runtime-dom.esm-bundler.js:333
    (Async: EventListener.handleEvent)
    addEventListener runtime-dom.esm-bundler.js:283
    patchEvent runtime-dom.esm-bundler.js:301
    patchProp runtime-dom.esm-bundler.js:369
    mountElement runtime-core.esm-bundler.js:3905
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    mountChildren runtime-core.esm-bundler.js:3975
    processFragment runtime-core.esm-bundler.js:4141
    patch runtime-core.esm-bundler.js:3784
    mountChildren runtime-core.esm-bundler.js:3975
    processFragment runtime-core.esm-bundler.js:4141
    patch runtime-core.esm-bundler.js:3784
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    componentEffect runtime-core.esm-bundler.js:4298
    reactiveEffect reactivity.esm-bundler.js:42
    effect reactivity.esm-bundler.js:17
    setupRenderEffect runtime-core.esm-bundler.js:4263
    mountComponent runtime-core.esm-bundler.js:4222
    processComponent runtime-core.esm-bundler.js:4182
    patch runtime-core.esm-bundler.js:3791
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868
    patch runtime-core.esm-bundler.js:3788
    mountChildren runtime-core.esm-bundler.js:3975
    mountElement runtime-core.esm-bundler.js:3896
    processElement runtime-core.esm-bundler.js:3868

My code is fairly simple, and changing the 'contents' of the Dialog makes no difference:

<Dialog
  v-model:visible="dialogVisible"
  :content-style="{overflow: 'visible'}"
  :header="dialogHeader"
>
<span>Hello</span>
</Dialog>

Unfortunately I can't replicate this in a plunkr, so I appreciate the bug may not be be in primevue, but the fact it appears on version upgrade seemed significant enough to report (the working plunkr with attempts to add the equivalent nesting in my own app, for reference/testing):

https://codesandbox.io/s/primevue-issue-template-forked-5zhgf

Please let me know if I can provide any other diagnostics or debugging to help with this!

  • Vue version: 3.0.11
  • PrimeVue version: 3.4.0
  • Browser: Chrome 89.0.4389.114 | Firefox 88
@mrichar1
Copy link
Contributor Author

My fault - I was missing import PrimeVue from 'primevue/config' and app.use(PrimeVue)`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrichar1