Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar overlay not removed after changing position #1823

Closed
wolfsblu opened this issue Nov 23, 2021 · 1 comment · Fixed by #3465
Closed

Sidebar overlay not removed after changing position #1823

wolfsblu opened this issue Nov 23, 2021 · 1 comment · Fixed by #3465
Assignees
@bahadirsofuoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.22.0

Comments

@wolfsblu
Copy link

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

CodeSandbox Case (Bug Reports)
Please demonstrate your case at CodeSandbox by using the issue template below. Issues without a test case have much less possibility to be reviewed in detail and assisted.

https://codesandbox.io/s/sad-wind-mxfmq?file=/src/App.vue

Current behavior
When changing the position of an open Sidebar the close button does not remove the overlay.

Expected behavior
The overlay gets removed after closing the Sidebar

  • Vue version: 3

  • PrimeVue version: 3.9.1

  • Browser: all
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 26, 2022
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 15, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.22.0 milestone Dec 15, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 15, 2022
@cagataycivici cagataycivici added the Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted label Jan 2, 2023
@cagataycivici cagataycivici removed this from the 3.22.0 milestone Jan 2, 2023
@cagataycivici cagataycivici removed the Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted label Jan 2, 2023
@cagataycivici cagataycivici added this to the 3.22.0 milestone Jan 2, 2023
@cagataycivici
Copy link
Member

Will be resolved via;

#3474

@bahadirsofuoglu bahadirsofuoglu mentioned this issue Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahadirsofuoglu bahadirsofuoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.22.0
Development

Successfully merging a pull request may close this issue.

Sidebar: reimplement primefaces/primevue
4 participants
@cagataycivici @wolfsblu @tugcekucukoglu @bahadirsofuoglu