Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable > Missing custom filterMatchMode #200

Closed
johannpinson opened this issue Feb 17, 2020 · 0 comments
Closed

DataTable > Missing custom filterMatchMode #200

johannpinson opened this issue Feb 17, 2020 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@johannpinson
Copy link

In the documentation (https://primefaces.org/primevue/#/datatable), the DataTable component have the filterMatchMode property which indicates :

Defines filterMatchMode; "startsWith", "contains", "endsWidth", "equals", "notEquals", "in" and "custom".

But this case in not present in the code.

let filterConstraint = FilterUtils[col.filterMatchMode];

It seems it only available inside the React package:
https://github.com/primefaces/primereact/blob/aae8b0dd46a99b925bb1827ef4cde06f00f85625/src/components/datatable/DataTable.js#L1107

let filterConstraint = filterMatchMode === 'custom' ? col.props.filterFunction : ObjectUtils.filterConstraints[filterMatchMode];

Is it planned to be added shortly to the component, or is it a typo issue in the docs?
(I hope it's just an oversight 😉)

Thanks

@cagataycivici cagataycivici self-assigned this Feb 27, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 27, 2020
@cagataycivici cagataycivici added this to the 1.0.5 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants