Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor infinite loop with some specific values #204

Closed
Sellec opened this issue Feb 20, 2020 · 4 comments
Closed

Editor infinite loop with some specific values #204

Sellec opened this issue Feb 20, 2020 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Sellec
Copy link

Sellec commented Feb 20, 2020

Maybe this is not a bug...im not good in vue.
In some specific scenario i got an infinite loop where vue's "data" field value changed by editor from 1st variant of content to 2nd and then to 1st and then to 2nd...
I create an example in jsfiddle - https://jsfiddle.net/Sellec/26fjhyqn/19/
You need to open this and run. All works fine. Then you need to open browser's developer console, and press example's button "Start hell spam in browser console". There is the method "startHell" which sets bugged value into property. And after that you will see lots of console output (from method "getId"). If you will see into this output, you will see that editor changes span.style="background-color color" to span.style="color background-color" and vise-versa.
An image example is here - https://c2n.me/4667NTV
I dont know if it is a quill's bug or primevue's editor wrapper bug.

@Sellec
Copy link
Author

Sellec commented Feb 20, 2020

This can be temporarly fixed by using "text-changed" event and "value" property for initial value binding.

@fairking
Copy link

fairking commented Feb 25, 2020

I have the same issue, moreover Quill inserts empty paragraphs everytime it loads text. It is very annoying for some of my users. So saving data it adds new empty paragraphs every time. I can see Quill is a bit dead now. Would be nice to switch to tiptap.

@fairking
Copy link

Added the same issue to the quill repo slab/quill#2948

@cagataycivici cagataycivici self-assigned this Feb 27, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 27, 2020
@cagataycivici cagataycivici added this to the 1.0.5 milestone Feb 27, 2020
@cagataycivici
Copy link
Member

I've applied the Editor code from the PrimeNG codebase which is much older and known to work with no issues for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants