Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR does not function for TabView / TabPanel #2470

Closed
1 task done
rtek opened this issue Apr 20, 2022 · 1 comment
Closed
1 task done

HMR does not function for TabView / TabPanel #2470

rtek opened this issue Apr 20, 2022 · 1 comment

Comments

@rtek
Copy link

rtek commented Apr 20, 2022

  • bug report

Reproduction
I dont know how to reproduce this in in codesandbox since it relates to HMR. Using the reproduction code does a full app reload on any change.

  1. Deploy the https://github.com/primefaces/primevue-quickstart-vite
  2. Replace HelloWorld.vue with
<!-- HelloWorld.vue --->
<template>
    <Button label="Foo" />
    <TabView>
        <TabPanel header="Bar">
        </TabPanel>
    </TabView>
</template>
  1. npm run dev
  2. Edit the Button.label and TabPanel.header
  3. Observe that HMR will update Button but not TabView

Current behavior
The TabPanel header does not re-render via HMR

Expected behavior
The TabPanel header should re-render to reflect the new value

What is the motivation / use case for changing the behavior?
We're evaluating vue UI frameworks and HMR is one of the key features. We also experienced this issue with DataTable but the TabView was the smallest reproducible example we could find.

Please tell us about your environment:

  • Windows 10
  • Webstorm
  • Chrome 100
quickstart@0.0.0 primevue-quickstart-vite
├── @vitejs/plugin-vue@2.3.1
├── primeicons@5.0.0
├── primevue@3.12.5
├── vite@2.9.5
└── vue@3.2.33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant