Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Calendar @month-change returns 0-11 and 1-12 #2696

Closed
flohoss opened this issue Jun 21, 2022 · 3 comments
Closed

Component: Calendar @month-change returns 0-11 and 1-12 #2696

flohoss opened this issue Jun 21, 2022 · 3 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Milestone

Comments

@flohoss
Copy link

flohoss commented Jun 21, 2022

Describe the bug

Event @month-change should return the same month range when changing with arrow keys or the drop down menu.
Currently it returns different values for the same month depending on the method.
Forward and Backwards arrows: 0-11
Drop down picker: 1-12

Screenshot 2022-06-21 143255
Screenshot 2022-06-21 143314
Select May, click backward and forward creates this:
Screenshot 2022-06-21 143341

Reproducer

https://codesandbox.io/s/zealous-johnson-761y2c

PrimeVue version

3.15.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Firefox 101, Chrome 102

Steps to reproduce the behavior

Click month forward and backward arrow, month will change from 0-11
Click on month to select month in drop down, month will change from 1-12

Expected behavior

Both methods should return the same number range

@flohoss flohoss added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 21, 2022
@flohoss flohoss changed the title Component: Calendar @month-change different months Component: Calendar @month-change returns 0-11 and 1-12 Jun 21, 2022
@James-Laidlaw
Copy link
Contributor

made a pull request that would patch it all to 1-12

@tugcekucukoglu tugcekucukoglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 28, 2022
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 28, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.15.1 milestone Jun 28, 2022
@tugcekucukoglu
Copy link
Member

Fixed via #2708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Projects
None yet
Development

No branches or pull requests

3 participants