Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: invalid 'placeholder' prop type (TS only) #2863

Closed
Raisenku opened this issue Aug 17, 2022 · 0 comments
Closed

InputNumber: invalid 'placeholder' prop type (TS only) #2863

Raisenku opened this issue Aug 17, 2022 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.16.2

Comments

@Raisenku
Copy link

Raisenku commented Aug 17, 2022 •
edited

Describe the bug

A commit in version 3.16.0 added the placeholder prop typing for the InputNumber element, however the type set in the .d.ts file is wrong, it should be string | undefined but was set to boolean | undefined, resulting in errors when validating a project / component using typescript.

This is the commit in question : c6d34c9

Reproducer

No response

PrimeVue version

3.16.0

Vue version

3.x

Language

TypeScript

Build / Runtime

TypeScript

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Raisenku Raisenku added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 17, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.17.0 milestone Aug 18, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.16.2
Development

No branches or pull requests
2 participants
@Raisenku @tugcekucukoglu