Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password: Unable to add invalid event listener after 3.16 #2880

Closed
dpogue opened this issue Aug 23, 2022 · 1 comment
Closed

Password: Unable to add invalid event listener after 3.16 #2880

dpogue opened this issue Aug 23, 2022 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dpogue
Copy link

dpogue commented Aug 23, 2022

Describe the bug

As of PrimeVue 3.16, adding @invalid="invalidHandler" to a Password component no longer calls the invalidHandler method when the underlying password input emits the invalid DOM event.

This worked in 3.15 and earlier. It's probably related to v-bind="$props" changing to v-bind="inputProps", but there doesn't seem to be a way to pass an event listener in through inputProps.

Reproducer

No response

PrimeVue version

3.16.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@dpogue dpogue added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 23, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.17.0 milestone Sep 1, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 1, 2022
@tugcekucukoglu
Copy link
Member

Sorry for the regression. Password was in a heavy accessibility development.

For the v3.17.0, invalid event could be used in two different ways:

<Password :inputProps="{oninvalid: onInvalid}"></Password>

or

<Password @invalid="onInvalid""></Password>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants