Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar: #item slot is never called #3177

Closed
paceband opened this issue Oct 28, 2022 · 3 comments
Closed

Menubar: #item slot is never called #3177

paceband opened this issue Oct 28, 2022 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@paceband
Copy link

Describe the bug

Slot #item is never called

Example:

<MegaMenu :model="items">
    <template #start>
        Before
    </template>
    <template #item="{item}">
        <a :href="item.url">{{item.label}}</a>
    </template>
    <template #end>
        After
    </template>
</MegaMenu>

Reproducer

No response

PrimeVue version

3.18.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The slot #item should be called.

@paceband paceband added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 28, 2022
@tugcekucukoglu
Copy link
Member

Can not replicate the issue. Here is a working example. https://codesandbox.io/s/jolly-glade-x6b0vr?file=/src/MegaMenuDemo.vue

@tugcekucukoglu tugcekucukoglu added Resolution: Invalid Issue or pull request is not valid in the latest version and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Oct 28, 2022
@paceband paceband changed the title MenuMenu: Slot #item is never called Menubar: Slot #item is never called Oct 28, 2022
@paceband
Copy link
Author

Sorry... I was talking about Menubar which does not make use of #item slot.

@tugcekucukoglu
Copy link
Member

We'll review it again.

Thanks,

@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Invalid Issue or pull request is not valid in the latest version Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 28, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.18.1 milestone Oct 31, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Oct 31, 2022
@tugcekucukoglu tugcekucukoglu changed the title Menubar: Slot #item is never called Menubar and TieredMenu: #item slot is never called Oct 31, 2022
@tugcekucukoglu tugcekucukoglu changed the title Menubar and TieredMenu: #item slot is never called Menubar: #item slot is never called Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants