Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload Missing TypeDefinitions for Slots #3335

Closed
kaipaysen opened this issue Nov 25, 2022 · 1 comment
Closed

FileUpload Missing TypeDefinitions for Slots #3335

kaipaysen opened this issue Nov 25, 2022 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.21.0

Comments

@kaipaysen
Copy link

kaipaysen commented Nov 25, 2022 •
edited

Describe the bug

TypeDefinitions for slots of FileUpload are missing.

https://github.com/primefaces/primevue/blob/master/src/components/fileupload/FileUpload.d.ts#L214-L223

Using FileUpload slot content like this

<template #content="{ files, removeFileCallback }">

leads to errors like these:

[vue-tsc] Property 'files' does not exist on type '{}'.
[vue-tsc] Property 'removeFileCallback' does not exist on type '{}'.

VsCode complains like this:
image

Reproducer

xxx

PrimeVue version

3.20.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@kaipaysen kaipaysen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.21.0 milestone Dec 2, 2022
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 2, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 2, 2022
@kaipaysen
Copy link
Author

Hi, thank you for your fix. Unfortunately VSCode is now complaining about another location:
image
Same message for removeUploadedFileCallback and removeFileCallback.

@kaipaysen kaipaysen mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.21.0
Development

No branches or pull requests
2 participants
@kaipaysen @tugcekucukoglu