Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Invalid typing for DataTableSortFieldType #3403

Closed
Magiczne opened this issue Dec 15, 2022 · 0 comments
Closed

DataTable: Invalid typing for DataTableSortFieldType #3403

Magiczne opened this issue Dec 15, 2022 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.22.0

Comments

@Magiczne
Copy link
Contributor

Describe the bug

Currently typings for DataTableSortFieldType are defined like so:

type DataTableSortFieldType = string | ((item: any) => string) | undefined;

But when inspecting this fields on DataGrid events, I can see that the null is a valid value too.
image

Reproducer

.

PrimeVue version

3.21

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Correct typings
@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 15, 2022
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 9, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.22.0 milestone Jan 9, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 9, 2023
@tugcekucukoglu tugcekucukoglu changed the title DataGrid: Invalid typing for DataTableSortFieldType DataTable: Invalid typing for DataTableSortFieldType Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.22.0
Development

No branches or pull requests
2 participants
@Magiczne @tugcekucukoglu