Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: dismissableMask not working when closable false #3560

Closed
kaipaysen opened this issue Jan 19, 2023 · 0 comments
Closed

Dialog: dismissableMask not working when closable false #3560

kaipaysen opened this issue Jan 19, 2023 · 0 comments
Assignees
@tugcekucukoglu
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.23.0

Comments

@kaipaysen
Copy link

Describe the bug

I've got a Dialog without the close 'X' and I'd like the dismissableMask Feature to be enabled. But as soon as I set closable = false the dismissableMask Feature stops working.

Documentation does not tell about this behaviour but code shows it here:
https://github.com/primefaces/primevue/blob/master/components/dialog/Dialog.vue#L233-L237

Reproducer

https://codesandbox.io/s/sad-zhukovsky-hm27zj?file=/src/App.vue:158-164

PrimeVue version

3.21.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

dismissableMask should work regardless of the closable property
@kaipaysen kaipaysen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2023
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 26, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.23.0 milestone Jan 26, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.23.0
Development

No branches or pull requests
2 participants
@kaipaysen @tugcekucukoglu