Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissableMask and closeOnEscape for Dialog #372

Closed
ilyavaiser opened this issue Jul 9, 2020 · 2 comments · Fixed by #444
Closed

dismissableMask and closeOnEscape for Dialog #372

ilyavaiser opened this issue Jul 9, 2020 · 2 comments · Fixed by #444
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
2.0.8

Comments

@ilyavaiser
Copy link

It would be nice to have built-in support for this behavior.
@cagataycivici
Copy link
Member

PrimeFaces, PrimeNG and PrimeReact have this, we sure can add it to Vue as well.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 10, 2020
@nestorrente
Copy link
Contributor

Hi everyone!

It would be nice if there was a way to close the dialog when the mask is clicked. For example, Vuetify's <v-dialog> emits a @click:outside event when its mask is clicked that is very useful.

Thank you for your great job!

@lochstar lochstar mentioned this issue Aug 18, 2020
Merged
@cagataycivici cagataycivici self-assigned this Aug 27, 2020
@cagataycivici cagataycivici added this to the 2.0.8 milestone Aug 27, 2020
@cagataycivici cagataycivici changed the title Esc key support to close the Dialog dismissableMask and closeOnEscape for Dialog Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
2.0.8
Development

Successfully merging a pull request may close this issue.

Added 'dismissableMask' and 'closeOnEscape' props to Dialog
3 participants
@cagataycivici @ilyavaiser @nestorrente