Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add Additional Toolbar Buttons To Preview #3771

Closed
DoubleJ-G opened this issue Mar 19, 2023 · 1 comment · Fixed by #3788
Closed

Image: Add Additional Toolbar Buttons To Preview #3771

DoubleJ-G opened this issue Mar 19, 2023 · 1 comment · Fixed by #3788
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@DoubleJ-G
Copy link

Describe the feature you would like to see added

When using the preview prop of the Image component I would like the Image component to have more configurability for the toolbar displayed in the top right either through props or slots.

Is your feature request related to a problem?

The most common thing I can think of wanting is to add an additional icon that is a button for quickly downloading an image. But there may also be other use cases for wanting to put more buttons into the toolbar so having the option to extend this would be ideal.

Describe the solution you'd like

I would like to either have a prop on the image component that lets me add items in the following format

{
   icon: string,
   callback: (src: string) => void
}

and/or

Add a #toolbar slot that allows me to override what is displayed in the top right of the preview.

Describe alternatives you have considered

No response

Additional context

Any feedback on how you think this should be implemented is welcome. Thanks for your time.

@DoubleJ-G DoubleJ-G added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Mar 19, 2023
@tugcekucukoglu tugcekucukoglu removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 24, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.26.1 milestone Mar 24, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 24, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request labels Mar 24, 2023
@DoubleJ-G
Copy link
Author

Hey @tugcekucukoglu thanks for taking a look at this. Unfortunately the changes you made here still don't allow adding any other buttons unless you want to take over the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants