Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Emit year-change event via navBackward and navForward #3811

Closed
colinstevens06 opened this issue Mar 27, 2023 · 4 comments
Closed
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@colinstevens06
Copy link

colinstevens06 commented Mar 27, 2023

Describe the bug

When the user is using the Calendar component as the Year Month Picker, it would be helpful if the year-change emit would fire when the user navigates to previous or next year.

Fix would likely be emitting the 'year-change' event in 2 places:

Reproducer

https://codesandbox.io/s/dreamy-firefly-oy6in1?file=/src/App.vue

PrimeVue version

3.21.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

In the code provided, use the 'next' and 'previous' buttons on the calendar to change year ... note that no information is logged via the @year-change emitted event

Expected behavior

@year-change should emit when using Year Picker and using the next/previous buttons

@colinstevens06 colinstevens06 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2023
@colinstevens06 colinstevens06 changed the title Component Name: Issue Title Calendar: Emit year-change event via navBackward and navForward Mar 27, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 28, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.27.0 milestone Mar 28, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 28, 2023
@tugcekucukoglu
Copy link
Member

If you have any solution, we would be grateful if you create a PR with the possible solution.

@colinstevens06
Copy link
Author

Cool - I'll work on a PR for this. Thanks!

@colinstevens06
Copy link
Author

@tugcekucukoglu FYI: created a PR for this issue: #3821

Thanks!

@tugcekucukoglu
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants