Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: Header accessibility issue #3904

Closed
havist opened this issue Apr 25, 2023 · 0 comments
Closed

Panel: Header accessibility issue #3904

havist opened this issue Apr 25, 2023 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@havist
Copy link

havist commented Apr 25, 2023

Describe the bug

Panel component breaks accessibility when custom header via slot is specified. It's because of this code:

<slot name="header">
    <span v-if="header" :id="ariaId + '_header'" class="p-panel-title" v-bind="ptm('title')">{{ header }}</span>
</slot>

That's mean, there is no id assigned to the header required by aria-labelledby at panel's body when slot is used.

Reproducer

https://codesandbox.io/p/sandbox/little-platform-xdt2l8

PrimeVue version

3.27.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Panel's header always has the id targeted by Panel's content.

@havist havist added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 25, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 26, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.28.0 milestone Apr 26, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants