Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable and TreeTable: new Paginator dropdown icon slots #3921

Closed
Magiczne opened this issue May 4, 2023 · 3 comments
Closed

DataTable and TreeTable: new Paginator dropdown icon slots #3921

Magiczne opened this issue May 4, 2023 · 3 comments
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.34.1

Comments

@Magiczne
Copy link
Contributor

Magiczne commented May 4, 2023

Describe the bug

3.27 introducted custom slots for icons. Unfortunately some of them are missing.
When using DataTable I cannot customize paginator icons for dropdowns RowsPerPageDropdown and JumpToPageDropdown.

As can be seen in code https://github.com/primefaces/primevue/blob/master/components/lib/paginator/Paginator.vue,
paginator is not exposing slots to pass to the dropdowns, so using paginator, dataTable, any any other component that is using paginator forces user to use icon provided by library.

Reproducer

PrimeVue version

3.27

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Ability to customize dropdown icons
@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 4, 2023
@Magiczne
Copy link
Contributor Author

@tugcekucukoglu This is a bug that prevents us from updating to the newer versions of primevue, which includes many bugfixes. Is this gonna be addressed soon?

@tugcekucukoglu
Copy link
Member

Definitely, I will implement this feature as soon as possible. I am unable to support you on Github as I am busy with Tailwind samples these days.

@tugcekucukoglu tugcekucukoglu added this to the 3.32.0 milestone Jul 31, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 31, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 31, 2023
@Magiczne
Copy link
Contributor Author

Sure, thanks for info!

This was referenced Aug 31, 2023
Open
Closed
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.33.1, 3.33.2 Sep 5, 2023
@tugcekucukoglu tugcekucukoglu changed the title DataTable/Paginator: Cannot customize icons for paginator dropdowns DataTable and TreeTable: new Paginator dropdown slots Sep 6, 2023
@tugcekucukoglu tugcekucukoglu changed the title DataTable and TreeTable: new Paginator dropdown slots DataTable and TreeTable: new Paginator dropdown icon slots Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.34.1
Development

No branches or pull requests
2 participants
@Magiczne @tugcekucukoglu