Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: remove margin from default style #4139

Closed
mozart77 opened this issue Jul 13, 2023 · 0 comments
Closed

Button: remove margin from default style #4139

mozart77 opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mozart77
Copy link

Describe the feature you would like to see added

Hi. I think margin set to 0 to buttons is bad idea because it makes you use !important rules to margin these elements.

BaseComponent.vue:9:

const buttonStyles = `
.p-button {
    margin: 0;
    display: inline-flex;
    cursor: pointer;
    user-select: none;
    align-items: center;
    vertical-align: bottom;
    text-align: center;
    overflow: hidden;
    position: relative;
} 

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response

@mozart77 mozart77 added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Jul 13, 2023
@mozart77 mozart77 changed the title Button: remove margin from inline styles Button: remove margin from default style Jul 13, 2023
@mertsincan mertsincan self-assigned this Jul 13, 2023
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 13, 2023
@mertsincan mertsincan added this to the 3.30.1 milestone Jul 13, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team Type: New Feature Issue contains a new feature or new component request labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants