Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable: Custom Column's Toggler Icon #4170

Closed
Asbarn opened this issue Jul 20, 2023 · 1 comment
Closed

TreeTable: Custom Column's Toggler Icon #4170

Asbarn opened this issue Jul 20, 2023 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Asbarn
Copy link

Asbarn commented Jul 20, 2023

Describe the bug

Can't provide custom toggler icon via Column's "rowtogglericon" slot. Only toggler from the TreeTable's slot "togglericon" but it doesn't provide rowExpanded or something else to check whether the row is expanded or not (ex. we want to rotate the custom icon on row expand )

Note: Also attributes from the pt's rowGroupToggler are not applied so we can't provide aria-label for toggler's button for accesibility

Reproducer

https://stackblitz.com/edit/nfvmaa-jh7cwq?file=src%2FApp.vue,src%2FDataTable.vue,src%2Frouter.js

PrimeVue version

3.29.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to stackblitz link
  2. Notice that Column's rowtogglericon content is not applied
  3. Uncomment TreeTable's togglericon and notice that it is being applied
  4. Also notice that data for rowGroupToggler is not being applied

Expected behavior

We can provide custom toggler icon for Column
We can check whether the row is expanded in the TreeTable's togglerIcon slot
We can provide attributes to the rowtoggler and its icon

@Asbarn Asbarn added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 20, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 20, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.30.3 milestone Jul 20, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 20, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.31.0, 3.32.0 Jul 25, 2023
@ZiadJ
Copy link

ZiadJ commented Aug 5, 2023

I haven't looked at the other issues but v-slot:togglericon="{ expanded }" seems to work fine

@tugcekucukoglu tugcekucukoglu modified the milestones: 3.33.1, 3.33.2 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants