Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: preview button is missing type="button" and submits forms by default #4249

Closed
m-kutnik opened this issue Aug 9, 2023 · 0 comments
Closed

Image: preview button is missing type="button" and submits forms by default #4249

m-kutnik opened this issue Aug 9, 2023 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.32.0

Comments

@m-kutnik
Copy link

m-kutnik commented Aug 9, 2023

Describe the bug

I noticed that the preview button inside Image component is missing the type="button". This leads to form submissions if the image component is used within the form.

Is this behavior intentional?

Reproducer

https://codesandbox.io/p/sandbox/boring-varahamihira-f9lwzx

PrimeVue version

3.31.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Open reproduction link
  2. Click on the PrimeVue logo
  3. onSubmit is called

Expected behavior

  1. Open reproduction link
  2. Click on the PrimeVue logo
  3. onSubmit is not called
@m-kutnik m-kutnik added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 9, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 9, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.31.1 milestone Aug 9, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.32.0
Development

No branches or pull requests
2 participants
@m-kutnik @tugcekucukoglu