Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Uncaught TypeError: getComputedStyle is not a function #4312

Closed
NeluQi opened this issue Aug 21, 2023 · 3 comments · Fixed by #4314
Closed

Dialog: Uncaught TypeError: getComputedStyle is not a function #4312

NeluQi opened this issue Aug 21, 2023 · 3 comments · Fixed by #4314
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.32.2

Comments

@NeluQi
Copy link

NeluQi commented Aug 21, 2023 •
edited

Describe the bug

image

var getComputedStyle = getComputedStyle(_this2.container);

image

Drag window and error

on 3.30.0 work

Reproducer

no

PrimeVue version

3.32.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@NeluQi NeluQi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
@melloware
Copy link
Member

Hmm looks SSR related? https://stackoverflow.com/questions/68995581/why-getcomputedstyle-method-does-not-work-properly-in-my-nuxt-app

@melloware
Copy link
Member

melloware commented Aug 21, 2023 •
edited

Introduced with #4252

Cc @Dmytro-Lukashenko

@Dmytro-Lukashenko Dmytro-Lukashenko mentioned this issue Aug 22, 2023
Merged
@Dmytro-Lukashenko
Copy link
Contributor

Hi guys! I've fixed this bug. It was the incorrect naming of the variable. I've changed getComputedStyle to containerComputedStyle. @melloware could you please check it?

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 23, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.2 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.32.2
Development

Successfully merging a pull request may close this issue.

Fix/fix dialog getComputedStyle error Dmytro-Lukashenko/primevue
4 participants
@melloware @NeluQi @Dmytro-Lukashenko @tugcekucukoglu