Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToastMessage: styleClass property is ignored #4454

Closed
Irelynx opened this issue Sep 14, 2023 · 0 comments
Closed

ToastMessage: styleClass property is ignored #4454

Irelynx opened this issue Sep 14, 2023 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Irelynx
Copy link

Irelynx commented Sep 14, 2023

Describe the bug

Documentation states that toast.add() accepts styleClass property, but in reality this property is ignored by ToastMessage component.

styleClass property was initially added in this commit (a4973cb), but in the current version of the source code this property doesn't exists.

In version 3.29 ToastMessage works as expected, but not in latest versions (3.33 or 3.34)

Reproducer

https://codesandbox.io/p/sandbox/delicate-smoke-n4xknr

PrimeVue version

3.34.1

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Open provided example and you will see the issue.

In this example you will see a Toast and a counter of specified classes in Toast on the current page.

If you will see 0 - it means that there is no classes on this page with the specified name, so the bug persists.

Expected behavior

styleClass must not be ignored and must be applied to ToastMessage container (?)

Also Toast.spec.js can be corrected with additional checks for this prop.

@Irelynx Irelynx added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 14, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 19, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.34.2 milestone Sep 19, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants