Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Buttonset with single button has wrong border radius #4467

Closed
maspetsberger opened this issue Sep 19, 2023 · 0 comments
Closed

Button: Buttonset with single button has wrong border radius #4467

maspetsberger opened this issue Sep 19, 2023 · 0 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@maspetsberger
Copy link
Contributor

Describe the bug

When using a buttonset with a single button, e.g. because the other buttons are hidden for the time being, then the border-radius is wrongly set to 0.

This is due to the CSS rules attached always to the first and last element respectively:

.p-buttonset .p-button:first-of-type {
border-top-right-radius: 0;
border-bottom-right-radius: 0;
}
.p-buttonset .p-button:last-of-type {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}

These selectors must only be active, when an element is :not(:only-of-type).

Reproducer

https://stackblitz.com/edit/ubrbwb?file=src%2FApp.vue

PrimeVue version

3.34.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@maspetsberger maspetsberger added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 19, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 20, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.34.2 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants