Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect Name: prop overshadowing #4743

Closed
petitkriket opened this issue Nov 2, 2023 · 2 comments
Closed

MultiSelect Name: prop overshadowing #4743

petitkriket opened this issue Nov 2, 2023 · 2 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@petitkriket
Copy link

petitkriket commented Nov 2, 2023

Describe the bug

https://github.com/primefaces/primevue/pull/4588/files

this.$primevue.config.locale.selectionMessageover shadows selectedItemsLabel when set and prevent any "contexutal" use

  1. having a global "generic" translation with "items" "elements" or whatever
  2. having a component and "local" and component specific translation matching the local context of the developer that needs the component

Reproducer

https://stackblitz.com/edit/ejwndf-bepfox?file=src%2FApp.vue

PrimeVue version

3.39.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

1.set a translation via the global API (in main.js)
1.set a local and contextual translation via the

Expected behavior

setting a global translation should work
setting a local translation via the prop should work.

local overrides the global API (similar as the pass through API)

@petitkriket petitkriket added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 2, 2023
@petitkriket
Copy link
Author

#4744

@tugcekucukoglu tugcekucukoglu added this to the 3.40.0 milestone Nov 3, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 3, 2023
@tugcekucukoglu
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants