Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Preview popup closes on 2nd click of disabled zoomOut and zoomIn in preview #4968

Closed
ajinkyas opened this issue Dec 15, 2023 · 1 comment · Fixed by #4976
Closed

Image: Preview popup closes on 2nd click of disabled zoomOut and zoomIn in preview #4968

ajinkyas opened this issue Dec 15, 2023 · 1 comment · Fixed by #4976
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.45.0

Comments

@ajinkyas
Copy link

Describe the bug

Preview popup closes if you keep clicking on disabled zoom in/out button.

Reproducer

https://codesandbox.io/s/hys89m

PrimeVue version

3.44.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Open the preview by clicking the image.
  2. Keep clicking zoom in/out button until it is disabled.
  3. Continue clicking on same disabled button 2 more times.
  4. Preview popup closes without clicking close button.

Expected behavior

Preview popup should not close.
@ajinkyas ajinkyas added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 15, 2023
@ajinkyas
Copy link
Author

This code line might have the issue https://github.com/primefaces/primevue/blob/master/components/lib/image/Image.vue#L107

isActionbarTarget is becoming false on click of disabled zoom in/out button.

@navedqb navedqb mentioned this issue Dec 18, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.45.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.45.0
Development

Successfully merging a pull request may close this issue.

fix: fix image preview close on disabled zoom button click qburst/primevue-1
2 participants
@ajinkyas @tugcekucukoglu