Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lara Light Teal: $highlightBg implementation defect #4980

Closed
tommie opened this issue Dec 19, 2023 · 0 comments
Closed

Lara Light Teal: $highlightBg implementation defect #4980

tommie opened this issue Dec 19, 2023 · 0 comments
Assignees
@tugcekucukoglu
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.45.0

Comments

@tommie
Copy link

tommie commented Dec 19, 2023

Describe the bug

Since 71b25f8, the lara-light-teal theme uses the same color for both bg and text-color:

  --highlight-bg: #0f766e;
  --highlight-text-color: #0f766e;

This isn't true for themes in general, not even lara-dark-teal. I assumed these colors were supposed to be used together.

This var doesn't seem used by PrimeVue, so perhaps it should be deprecated?

Reproducer

n/a

PrimeVue version

3.43.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@tommie tommie added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 19, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.45.0 milestone Dec 20, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 20, 2023
@tugcekucukoglu tugcekucukoglu changed the title theme: lara-light-teal has --highlight-bg == --highlight-text-color Lara Light Teal: $highlightBg implementation defect Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.45.0
Development

No branches or pull requests
2 participants
@tommie @tugcekucukoglu