Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Sort icons are not showing correct amount directions #4981

Closed
onursenture opened this issue Dec 19, 2023 · 4 comments
Closed

Table: Sort icons are not showing correct amount directions #4981

onursenture opened this issue Dec 19, 2023 · 4 comments
Assignees
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@onursenture
Copy link
Member

Reported on the PrimeLand:

image
@onursenture onursenture added the Core Team Issue or pull request has been *opened* by a member of Core Team label Dec 19, 2023
@onursenture onursenture self-assigned this Dec 19, 2023
@onursenture onursenture changed the title Table: Sort icons are not showing correct directions Table: Sort icons are not showing correct amount directions Dec 19, 2023
@onursenture
Copy link
Member Author

Before:

Screen Shot 2023-12-19 at 18 36 35
Screen Shot 2023-12-19 at 18 36 40


After:

Screen Shot 2023-12-19 at 18 37 14
Screen Shot 2023-12-19 at 18 37 17

@onursenture onursenture added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 19, 2023
@onursenture onursenture added this to the 3.45.0 milestone Dec 19, 2023
@Voltra
Copy link

Voltra commented Dec 20, 2023

It seems to me that this was the case before (in v2 IIRC), but now this feels like a regression. It's the same icon that's just flipped upside down and makes it (or just the arrow) ambiguous.

Simply switching the icons from the "before" case would have made more sense and kept everything meaningful.

cf. #4708 and #3732

@onursenture
Copy link
Member Author

It seems to me that this was the case before (in v2 IIRC), but now this feels like a regression. It's the same icon that's just flipped upside down and makes it (or just the arrow) ambiguous.

Simply switching the icons from the "before" case would have made more sense and kept everything meaningful.

cf. #4708 and #3732

I don't understand why you think it's ambiguous. If we're discussing the icons used in the 'After' section in my previous comment, the arrows' direction and the amount indicator parts are in the correct orientation to prevent confusion.

@Voltra
Copy link

Voltra commented Dec 20, 2023

They aren't though. In the after case, ascending order, the arrow goes from the bigger bar to the smaller bar which is quite the opposite of ascending order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants