Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: maximizable broken if dialog moved #5048

Closed
antlionguard opened this issue Jan 9, 2024 · 0 comments · Fixed by #5049
Closed

Dialog: maximizable broken if dialog moved #5048

antlionguard opened this issue Jan 9, 2024 · 0 comments · Fixed by #5049
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.47.0

Comments

@antlionguard
Copy link
Contributor

antlionguard commented Jan 9, 2024 •
edited

Describe the bug

If you drag Dialog component before clicking maximize button that brokes maximizing.

image

Reproducer

https://primevue.org/dialog/#maximizable

PrimeVue version

3.45.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

Chrome 120.0.6099.199

Steps to reproduce the behavior

  1. Open maximizable dialog.
  2. Drag dialog 1px or more (not important how much is that)
  3. And click maximize icon.

Expected behavior

Maximize button must make the dialog component full screen.
@antlionguard antlionguard added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 9, 2024
@navedqb navedqb mentioned this issue Jan 9, 2024
Merged
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 11, 2024
@mertsincan mertsincan added this to the 3.47.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.47.0
Development

Successfully merging a pull request may close this issue.

fix: fix maximizable issue in Dialog component when moved qburst/primevue-1
2 participants
@mertsincan @antlionguard