Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Legacy Themes #5201

Closed
cagataycivici opened this issue Feb 3, 2024 · 6 comments
Closed

Deprecate Legacy Themes #5201

cagataycivici opened this issue Feb 3, 2024 · 6 comments
Assignees
Labels
Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Milestone

Comments

@cagataycivici
Copy link
Member

As a prerequisite of the new theming api of V4, deprecate the legacy themes as they won't be available in v4.

  • Arya
  • Bootstrap (Replacement would be Lara)
  • Fluent
  • Luna
  • Mira
  • Nano
  • Nova
  • Rhea
  • Saga
  • Tailwind
  • Vela
  • Viva
@cagataycivici cagataycivici self-assigned this Feb 3, 2024
@cagataycivici cagataycivici added the Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release label Feb 3, 2024
@cagataycivici cagataycivici added this to the 3.48.0 milestone Feb 3, 2024
@minzdrav
Copy link

minzdrav commented Feb 5, 2024

Hi @cagataycivici
What will happen to the custom theme that we created for our project? We used mytheme as the base for our theme.
How hard it will be to migrate to v4? Will you provide a migration guide?

@mikekidder
Copy link

@minzdrav - One of the technical lead of PrimeTek is writing a Primeflex to Tailwind migration tool.

See more discussion on the Discord | Primeland | #primeflex channel -- Message Link

@pontsci
Copy link

pontsci commented Feb 12, 2024

Hi @cagataycivici What will happen to the custom theme that we created for our project? We used mytheme as the base for our theme. How hard it will be to migrate to v4? Will you provide a migration guide?

Same here, we used a custom theme and when we go from 3.46 -> 3.47/3.48 our entire theme breaks in our Nuxt project. Hoping we have some way to migrate, otherwise it seems our current project will be stuck on 3.46 for a while.

@mikebouzidis-aurizon
Copy link

mikebouzidis-aurizon commented Feb 22, 2024

We're having exactly the same issue. I don't understand why such a significant breaking change was released as a minor version.

We're going to be stuck on 3.46 until this migration tool is built and we can migrate

@n00ge
Copy link

n00ge commented Mar 5, 2024

Re-iterating what the others said above. This impacts (breaks) a project I work on as well. Introducing a breaking change like this on a minor version is a huge impact. I'm curious how this affects others decisions to move away from PrimeVue entirely.

Will there be any migration tools to navigate from tailwind to V4?

@pontsci
Copy link

pontsci commented Mar 12, 2024

Unfortunately, this was a pretty big hit for my company's trust of the library and we have since moved on to a new framework. We need to have up-to-date, stable component frameworks that don't introduce breaking changes into a minor version patch without advance notice. So, unfortunately, after a solid year with Primevue, we have since moved on to a different component library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Deprecated Issue contains a deprecated component. The component will be removed in any future release
Projects
None yet
Development

No branches or pull requests

6 participants