Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputOTP - integerOnly doesn't work with number pad #5329

Closed
yureckey opened this issue Feb 23, 2024 · 10 comments
Closed

inputOTP - integerOnly doesn't work with number pad #5329

yureckey opened this issue Feb 23, 2024 · 10 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@yureckey
Copy link

Describe the bug

with integerOnly I cannot use numbers pad.

Reproducer

https://primevue.org/inputotp/#integeronly

PrimeVue version

3.49.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chrome 121, Windows 10

Steps to reproduce the behavior

https://primevue.org/inputotp/#integeronly
use keyboard top row with numbers - input works
use number pad (right side of keyboard) - input doesn't work

Expected behavior

numbers should work for both top row and number pad

@yureckey yureckey added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 23, 2024
@franmc01
Copy link

franmc01 commented Mar 2, 2024

Solution here: #5358

@franmc01
Copy link

franmc01 commented Mar 9, 2024

@melloware How does the reviews work? I want to contribute :)

@melloware
Copy link
Member

@franmc01 its easy just submit a PR and PrimeTek will review it or reject it!

@tugcekucukoglu tugcekucukoglu added this to the 3.50.0 milestone Mar 13, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 13, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 13, 2024
@yureckey
Copy link
Author

Hmm, I'm trying just released 3.50 and it is even more broken somehow 🤔
I'm still on Windows 10, last Chrome - any number key pressed doesn't show in https://primevue.org/inputotp/#integeronly
not regular number keys, not additional

@sinchijackal
Copy link

Hmm, I'm trying just released 3.50 and it is even more broken somehow 🤔 I'm still on Windows 10, last Chrome - any number key pressed doesn't show in https://primevue.org/inputotp/#integeronly not regular number keys, not additional

The same issue is observed on iOS 17.4

@franmc01
Copy link

@yureckey I had resolved that situation in the PR #5358

but it was not accepted, in that case I sent some fixes from the landing

@franmc01 franmc01 mentioned this issue Mar 15, 2024
@franmc01
Copy link

There I sent the pr again, from my tests the problem is that event.keyCode is used in favor of event.key; From what I saw the first one is obsolete. I changed the implementation to event.key and it worked perfectly, I had even added the validation that when you copy a code it is also validated that it is numerical because in the current one it is either numerical or it does not let you copy any string

@Payn
Copy link

Payn commented Mar 20, 2024

Any update to this? It's not fixed, IntegerOnly still doesn't accept numbers in version 3.50.

@franmc01
Copy link

I sent this PR: #5424

@franmc01
Copy link

No accepted :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants