Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputOtp: wrong usage of inputmode #5382

Closed
NicolaIsotta opened this issue Mar 6, 2024 · 0 comments · Fixed by #5385
Closed

InputOtp: wrong usage of inputmode #5382

NicolaIsotta opened this issue Mar 6, 2024 · 0 comments · Fixed by #5385
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@NicolaIsotta
Copy link

Describe the bug

Premise: I'm not a PrimeVue user, I'm developing InputOtp for the primefaces extensions project (primefaces-extensions/primefaces-extensions#1455 primefaces-extensions/primefaces-extensions#1453) and I'm trying to keep things aligned.
While checking PrimeVue implementation, I've seen that there's a wrong usage of the inputmode attribute

Reproducer

https://primevue.org/inputotp

PrimeVue version

3.49.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Navigate to https://primevue.org/inputotp and go to the Integer Only section.
This is the rendered html:
image

Expected behavior

number is not a valid value for inputmode. It should be numeric instead. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode

@NicolaIsotta NicolaIsotta added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 6, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 13, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.50.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants