Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding ProgressSpinner colors doc error #589

Closed
cooliopas opened this issue Oct 21, 2020 · 1 comment
Closed

Overriding ProgressSpinner colors doc error #589

cooliopas opened this issue Oct 21, 2020 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@cooliopas
Copy link

On docs at https://primefaces.org/primevue/showcase/#/progressspinner says you can change spinner colors by overriding:

@keyframes ui-progress-spinner-color {

but it should be:

@keyframes p-progress-spinner-color {

Also, I had to change the order of imports to have it working, otherwise the original keyframes animation css was applied.

So, instead of using the imports order like said on https://github.com/primefaces/primevue-quickstart/blob/master/src/main.js:

import { createApp } from 'vue'
import App from './App.vue';

import ProgressSpinner from 'primevue/progressspinner';

import 'primevue/resources/themes/saga-blue/theme.css';
import 'primevue/resources/primevue.min.css';
import 'primeicons/primeicons.css';

const app = createApp(App);

... I had to change to:

import { createApp } from 'vue'

import ProgressSpinner from 'primevue/progressspinner';

import App from './App.vue';

import 'primevue/resources/themes/saga-blue/theme.css';
import 'primevue/resources/primevue.min.css';
import 'primeicons/primeicons.css';

const app = createApp(App);

PrimeVue is amazing! Already using it with Vue 3. Thanks

@cagataycivici cagataycivici self-assigned this Oct 22, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 22, 2020
@cagataycivici cagataycivici added this to the 3.0.1 milestone Oct 22, 2020
@cagataycivici cagataycivici changed the title Overriding ProgressSpinner colors Overriding ProgressSpinner colors doc error Oct 22, 2020
@cagataycivici
Copy link
Member

Got it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants