Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named routes support for Menu Components #594

Closed
guillaume-blz opened this issue Oct 23, 2020 · 2 comments
Closed

Named routes support for Menu Components #594

guillaume-blz opened this issue Oct 23, 2020 · 2 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@guillaume-blz
Copy link

Is it possible to make fully compatible menu items with named route? Doc: https://router.vuejs.org/guide/essentials/named-routes.html

Actually isActive method of the TabMenu component check only with the string path declaration.

Example:

const items = [
  {
    label: 'Dashboard',
    to: { name: 'dashboard' },
  },
  {
    label: 'Post',
    to: { name: 'post', params: { id: 1570 } },
  },
];
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 25, 2020
@cagataycivici
Copy link
Member

Named routes work fine but TabMenu only is an exception as it checks paths, there is room for improvement here.

@cagataycivici cagataycivici changed the title PrimeVue 3 Menu components with named routes Named routes support for Menu Components May 10, 2021
@cagataycivici cagataycivici self-assigned this May 11, 2021
@cagataycivici cagataycivici added this to the 3.5.0 milestone May 11, 2021
@cagataycivici
Copy link
Member

Tracked at;

#830

@cagataycivici cagataycivici removed their assignment May 14, 2021
@cagataycivici cagataycivici removed this from the 3.5.0 milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants