Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: missing loadingIcon passthrough option in documentation #5964

Closed
goldengecko opened this issue Jun 25, 2024 · 1 comment
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@goldengecko
Copy link

Describe the bug

In the pass through diagram, item 9 is the loading icon. This is missing from the table of options below. This means that all the items below this are incorrectly numbered. Looking at packages/primevue/src/multiselect/MultiSelect.vue:50 it appears that the missing item should be named loadingIcon

Reproducer

n/a

PrimeVue version

4.0.0-rc2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Documentation error.

Expected behavior

Correct documentation

@goldengecko goldengecko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 25, 2024
@goldengecko
Copy link
Author

I have been trying to work out what needs to be changed to get the styling working converting from v3 styles to v4 styles, and have found that the image in the v4 documentation is incorrect and the mapping from v3 to v4 is a bit complex in part due to replacement of standard elements with components, and in part to some things apparently being undocumented. I have tried to put together a list of items in v4 and where they have come from in v3 so that I can get my head around the updates required for styling.

Hopefully this will be useful in updating the documentation:

  • root (value 1)
  • labelContainer (value 2)
  • label (value 3)
  • token -> chipItem (value 4)
  • tokenLabel -> pcChip (value 5) (this used to be a separate label, but is now replaced with a Chip component.)
  • removeTokenIcon -> Labelled as value 6 on the diagram but no corresponding item in the new configuration since it becomes part of the pcChip settings
  • trigger -> dropdown (value 7)
  • loadingIcon (undocumented)
  • dropdownIcon (value 8)
  • panel -> overlay (value 9)
  • header (value 10)
  • headerCheckbox -> pcHeaderCheckbox (value 11) (contains an icon property)
  • filterContainer -> pcFilterContainer (value 12) - (converted from a div to an IconField)
  • filterInput -> pcFilter (value 13) - (converted from input to InputText)
  • pcFilterIconContainer (value 14) - new item that wasn't there in v3
  • filterIcon (value 15)
  • closeButton (old value 16) -> no longer there in v4 - appears to be covered by the use of IconField for value 14
  • closeIcon (old value 17) -> also covered by the IconField
  • wrapper -> listContainer (value 16)
  • virtualScroller (value 17)
  • list (value 18)
  • itemGroup -> optionGroup (value 19)
  • item -> option (value 20)
  • option -> optionLabel (value 21)
  • itemCheckbox -> pcOptionCheckbox (value 22) (contains an icon key)
  • emptyMessage (value 23)
  • hiddenInputWrapper (undocumented) -> hiddenInputContainer (value 24)
  • hiddenFirstFocusableEl (value 25)
  • hiddenEmptyMessage (undocumented)
  • hiddenFilterResult (value 26)
  • hiddenInput (old value 26) -> hiddenInput (undocumented)
  • hiddenSelectedMessage (value 27)
  • hiddenLastFocusableEl (value 28)
  • transition (value 30)

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 26, 2024
@tugcekucukoglu tugcekucukoglu modified the milestone: 4.0.0-rc.3 Jun 26, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants