You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋:skin-tone-2: hi friends, i’m running into some testing issues around using the Autocomplete component and i was wondering what we were missing
for context, here’s the PR we’re working with: https://github.com/github/delorean/pull/127
TypeError: Failed to execute 'addEventListener' on 'EventTarget': parameter 3 dictionary has member 'signal' that is not of type 'AbortSignal'.
❯ exports.convert node_modules/jsdom/lib/jsdom/living/generated/AddEventListenerOptions.js:53:11
❯ HTMLDivElement.addEventListener node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:139:46
❯ Module.focusZone node_modules/@primer/behaviors/dist/esm/focus-zone.js:248:15
246| });
247| let elementIndexFocusedByClick = undefined;
248| container.addEventListener('mousedown', event => {
| ^
249| if (event.target instanceof HTMLElement && event.target !== document.activeElement) {
250| elementIndexFocusedByClick = focusableElements.indexOf(event.target);
❯ node_modules/@primer/react/lib-esm/hooks/useFocusZone.js:21:34
It appears that jsdom is throwing when trying to add an event listener, and appears that's due to the primer/behaviors focusZone attempting to pass a signal, which appears to conflict with the accepted signal jsdom expects.
Primer/react uses jest (with jsdom) to test this component, which is confusing to me, given there's no indication that it currently has issues here
This leads me to think either
a version of JSDOM begins breaking
vite and jest somehow differ in the globals they send to jsdom in this scenario
I suggested a workaround, temporarily, mocking focusZone entirely -
but this changes behavior of the autocomplete, and is not ideal
Steps to reproduce
start a project with vite/vitest
render an AutoComplete in a test using the jsdom environment
see jsdom throw
Version
All related versions of multiple packages
It's unclear to me whether this problem already exists and is becoming clear due to versioning of react and testing-libary, is due to something with how vite interops globals compared to jest, or if this is jest/jsdom.
Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.
related - primer/react#2454
Description
This issue may better exist on primer/behaviors (or even upstreamed to jsdom if we can repro simply enough)
Initially reported in slack by @itsbagpack
https://github.slack.com/archives/C01L618AEP9/p1666186967969609
👋:skin-tone-2: hi friends, i’m running into some testing issues around using the Autocomplete component and i was wondering what we were missing
for context, here’s the PR we’re working with: https://github.com/github/delorean/pull/127
It appears that jsdom is throwing when trying to add an event listener, and appears that's due to the primer/behaviors
focusZone
attempting to pass a signal, which appears to conflict with the accepted signal jsdom expects.Primer/react uses jest (with jsdom) to test this component, which is confusing to me, given there's no indication that it currently has issues here
This leads me to think either
a version of JSDOM begins breaking
vite and jest somehow differ in the globals they send to jsdom in this scenario
I suggested a workaround, temporarily, mocking
focusZone
entirely -but this changes behavior of the autocomplete, and is not ideal
Steps to reproduce
start a project with vite/vitest
render an AutoComplete in a test using the jsdom environment
see jsdom throw
Version
All related versions of multiple packages
It's unclear to me whether this problem already exists and is becoming clear due to versioning of react and testing-libary, is due to something with how vite interops globals compared to jest, or if this is jest/jsdom.
Browser
No response
The text was updated successfully, but these errors were encountered: